The GuardianMen’s short shorts, an item of clothing forever caught in the crosshairs of a sartorial culture war between subversive and suggestive and re